dateparser icon indicating copy to clipboard operation
dateparser copied to clipboard

Fixing: flake8 E402 and windows setup.py not working

Open gavishpoddar opened this issue 2 years ago • 2 comments

This PR Fixes,

  • Fixing E402 module-level import, not at top of file in dateparser/docs/conf.py
  • Fixing UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 1442: character maps to in Windows

Note: This change makes it possible to run pip install . . But tox is not entirely fixed.

Please suggest.

gavishpoddar avatar Jul 29 '21 10:07 gavishpoddar

Codecov Report

Merging #955 (e36d79b) into master (41f9478) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #955   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         234      234           
  Lines        2694     2694           
=======================================
  Hits         2648     2648           
  Misses         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41f9478...e36d79b. Read the comment docs.

codecov[bot] avatar Jul 29 '21 10:07 codecov[bot]

Hi, I have made the changes

gavishpoddar avatar Aug 07 '21 13:08 gavishpoddar