dateparser icon indicating copy to clipboard operation
dateparser copied to clipboard

Published 20 hours ago • verified publisher icon scrapinghub

Updates in IT translations

Open federicodilo opened this issue 3 years ago • 3 comments

Added few other translations to which replace all previous Italian PRs

Mergeable after #1049

federicodilo avatar Sep 16 '22 22:09 federicodilo

Thank you for your PR @federicodilo Could you please add some tests to this PR that cover these changes? Thanks in advance.

serhii73 avatar Oct 07 '22 13:10 serhii73

It should be enough, please feel free to tell me if it's not :)

ghost avatar Oct 07 '22 22:10 ghost

I have run the tests and it seems to work, it is possible to merge at will.

ghost avatar Oct 08 '22 13:10 ghost

Could you keep the extra comma at the end of lists in Python files? Unlike in JSON, in Python it is allow and even encouraged. And you seem to have edited an unrelated (Ukranian) file making that change (maybe it was your IDE making that change automatically?).

Gallaecio avatar Oct 24 '22 21:10 Gallaecio

Well the edits on Ukrainian file were added from IDE to do not overwrite the changes not done by me. I've reinserted the commas to uniform the files; still it fails to compile though.

Any idea? :)

ghost avatar Oct 24 '22 21:10 ghost

The JSON file cannot have the extra comma, that is a JSON syntax error. Only Python allows the extra comma.

Gallaecio avatar Oct 24 '22 22:10 Gallaecio

Hi @federicodilo Could you please resolve the conflicts? Thanks in advance.

serhii73 avatar Nov 11 '22 07:11 serhii73

If you are not familiar with merge conflicts, I recommend reading the GitHub docs about them.

Gallaecio avatar Nov 14 '22 08:11 Gallaecio