dateparser
dateparser copied to clipboard
fix: change tzlocal version
tzlocal version 4.0 just dropped and it doesn't work on many devices. wouldn't it be nice to set the dependency to a specific version that works everywhere before the maintainers of tzlocal
will figure it out?
If version 4 does not work with dateparser, then we can add <4
to the version requirement until we find time to add support for 4+. But we should not freeze a dependency version in a library, we should give a range of supported versions instead.
Codecov Report
Merging #1006 (b87e6d4) into master (8af4f29) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 234 234
Lines 2694 2694
=======================================
Hits 2648 2648
Misses 46 46
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8af4f29...b87e6d4. Read the comment docs.
Also, changes in tox.ini
won’t matter much, you need to change setup.py
.
should I create another PR?
No need. Add <4 to the tzlocal restriction of setup.py, with a comment to indicate the reason why version 4 does not work.
How complex are the changes to tzlocal? Maybe it would be easier to change dateparser to support the new version as well.
I haven't looked into it
For the proper fix there is https://github.com/scrapinghub/dateparser/issues/1001 reported.
Hi @pasenidis @Gallaecio, Is this problem still relevant, or can we close this issue?
Closing as per https://github.com/scrapinghub/dateparser/issues/1001#issuecomment-1311890482