realms-wiki icon indicating copy to clipboard operation
realms-wiki copied to clipboard

python3 porting status

Open jelmer opened this issue 7 years ago • 8 comments

The README mentions that Python3 support is a work in progress; is there a more detailed status description somewhere? What is left to do?

jelmer avatar May 17 '18 10:05 jelmer

@jelmer I'm not sure what else needs to be done. I have not been actively developing realms lately and maintainers are welcome.

scragg0x avatar May 17 '18 17:05 scragg0x

I might contribute a patch or two if I find issues :)

I was also considering packaging realms for Debian, but that may not be the greatest idea if the project is in a dormant state.

jelmer avatar May 17 '18 18:05 jelmer

PRs welcome, just keep in mind any breaking changes.

I think a deb is a good idea. Ideally realms would be much easier to setup if there existed a deb w/ ppa. I think first the code needs to be stable, secure, and existing features completed.

scragg0x avatar May 17 '18 19:05 scragg0x

It fails pretty early for me; i.e. reload isn't available in python3 and used in the third line or so of realms/init.py.

jelmer avatar May 20 '18 18:05 jelmer

Hmm, that whole bit with setting sys.setdefaultencoding seems dubious to me. Is that just to avoid explicit utf-8 decoding of bytes in other locations? Is the calling of reload just to detect python 3?

gazpachoking avatar May 21 '18 04:05 gazpachoking

That bit should be removed, it was added awhile back in an attempt to fix encoding when printing to the console... The reload is there as a hack to bring the attribute back so it can be set.

scragg0x avatar May 21 '18 19:05 scragg0x

Do you know if there is any code relying on that still? I agree it would be nice to remove it, for more than just supporting python 3 reasons.

gazpachoking avatar May 22 '18 03:05 gazpachoking

FWIW I've packaged the missing (Python3) dependencies for realms-wiki in Debian unstable. They should make it out to Ubuntu in a few months.

(Note that Debian no longer accepts new Python2 packages)

jelmer avatar May 30 '18 20:05 jelmer