Sheridan C Rawlins

Results 97 comments of Sheridan C Rawlins

hi - sent an email with fuller logs… if you have any public slack/irc/other connectivity to chat please LMK if you have patience to troubleshoot closer to "live"

Well the latest debugging with @williammartin has shown that 1. We have a Host directive in the `$HOME/.ssh/config` 1. If we set GH_HOST to _that_ instead of the name used...

I suppose, we could learn about, and provide a yaml file if that would fix the behavior- I think we want/need the REST stuff to go to the named host,...

> Collecting known hosts (e.g. those in hosts.yml or GH_HOST env var, or github.com) I don't see mention of `hosts.yml` in the https://cli.github.com/manual/gh_pr_create (don't see any search there either, so...

Interesting, yes, we do git push before invoking gh pr create… I can try adding that flag to see if it helps… stay tuned; will update this comment. * Seems...

> > @scr-oath can you please review? > > Please provide the next steps from our side. We've implemented all the requested changes. I still see a bunch of unresolved...

> @scr-oath Apologies for any confusion. I'll review what hasn't been addressed yet and respond to @bsardo accordingly. Also, I see one dangling comment from me still https://github.com/prebid/prebid-server/pull/4117#discussion_r1937810771 I see...

Here's a rough draft of something that might work externally, but I'm sure it could be written nicer if internal: ```go package deepset import ( "github.com/bytedance/sonic/ast" "slices" ) // GetByPathDeep...

Absolutely agree that GetByPath shouldn't modify anything… so maybe that `GetByPathDeep`, if named more appropriately would still be useful. Naming is hard… maybe something like `EnsurePath`? Point is to do...

Yes, I agree - and if there are multiple triggers such as `schedule=[Dataset("one"), Dataset("two")]` it would be quite generally useful to get information about each triggering event - I'm not...