scout_apm_python icon indicating copy to clipboard operation
scout_apm_python copied to clipboard

Remove use of datetime.utcnow()

Open adamchainz opened this issue 1 year ago • 1 comments

Fixes #799.

This needs further testing to check whether the issue from #400 is fixed in the core agent or if it needs handling here, by changing the formatting to remove timezone info.

I no longer have a working dev setup for this though, so I will leave that testing in your hands. (I used to be the maintainer of this package.)

adamchainz avatar Oct 04 '24 11:10 adamchainz

Thank you for this, Adam. And for all your work here and with Django. We'll run it through the test apps... which you have also contributed. This is one of those changes that my soul knows is good for python but is not exactly going to be painless. We will schedule a look at the core agent to check out options.

lancetarn avatar Oct 04 '24 19:10 lancetarn

Work is in-flight to handle multiple timestamp formats in the Core Agent.

lancetarn avatar Oct 30 '24 04:10 lancetarn

I think the Core Agent can actually handle offset information in an expected format as-is. I've collected these changes and made some tiny tweaks in #801 and will bring them home there. Thank you so much again for the major effort here!

lancetarn avatar Nov 04 '24 16:11 lancetarn