scout_apm_python icon indicating copy to clipboard operation
scout_apm_python copied to clipboard

Support aioredis & aioelasticsearch

Open yoav-orca opened this issue 4 years ago • 1 comments

Hi, we love using scout but we are missing the async support in python, specifically for Redis (aioredis) & ElasticSearch (aioelasticsearch), are there any plans to support them? Will you accept PRs for adding support for them?

yoav-orca avatar Jul 18 '20 07:07 yoav-orca

Hi @yoav-orca

Thanks for the support. We don't have any specific issues tracking aioredis or aioelasticsearch. We'd love to expand support for them though.

If you're interested in instrumenting them you can probably implement something within your own project or a fork of scout-apm. The instruments submodule contains our current instrumentation of libraries: https://github.com/scoutapp/scout_apm_python/tree/master/src/scout_apm/instruments . The main difficulty you'll find with making an implementation within scout-apm is keeping all async code in the scout_apm.async_ module because we support Python 2 still. However you look into adding instrumentation we'd love to see it and will consider PR's.

Thanks,

Adam

adamchainz avatar Jul 20 '20 10:07 adamchainz