scout-apm-php
scout-apm-php copied to clipboard
DerivedSource::architecture could return 'unknown'
Currently, \Scoutapm\Config\Source\DerivedSource::architecture could return unknown if php_uname('m') returns anything other than i686 or x86_64.
Question: should we throw an exception, since we don't support the architecture?
@cschneid please advise? I think probably just throwing a hard exception here seems sensible?
Either a hard exception, or just default to i686 and see if it works? I'm not sure of the scope of the values that can come out of the arch call.
At some point, I could see us adding ARM or similar, but nobody has requested it yet.
Logging a clear error message or exception would be ideal, currently a 404 error is logged due to the unknown-unknown-linux-musl tarball not existing and it isn't immediately obviously why. We deployed scout onto some ec2 t4g instances today and it failed to work, despite the extension appearing to install via pecl fine
It does fail gracefully when failing the download, so throwing an exception would be a bc
I guess this is me asking for ARM support :)