Model.objects.get does not respect deleted_at field

[davidhyman]

Calling .get on the manager still returns soft deleted records. For now, this is my workaround:

class BaseManager(SoftDeleteManager):
    def get(self, *pargs, **kwargs):
        return self.filter().get(*pargs, **kwargs)

The issue also affects get_or_create by virtue of it using the get method, causing integrity errors with unique constraints (not handled by the workaround). e.g. for MyModel already containing a soft deleted record 'foo':

MyModel.objects.get_or_create(unique_field1='foo')

• get fails because it is now correctly ignoring the soft deleted record
• create fails because there is already a 'foo' record for unique_field1

[shayneoneill]

Yes, that would be correct behavior. Soft delete isn't magic. If your design doesn't account for the fact that the keyspace will be partly occupied by hidden records, then the design will fail. Because soft-delete is about enabling restoring the record, if a new record occupies its keyspace, that restoration will fail. This behavior thus is precisely as expected. That said, the mixin for get is useful.

[glynjackson]

@davidhyman I wouldn't have expected it to be applied automatically, please don't add this in. If you are using something like an API I expect the default to show all, allows you to apply filters for deleted or non-deleted items.