scottyab
Only show symbol when edittext has focus
Hi,
I'd really like to have the option to only show the icon when the edit text has focus. If this is something you'd be interested in adding, I'm happy to submit a pull request.
Hey @evolutionise, yeah that would be useful, thanks. Maybe make it optional with method call and a custom xml attribute . i.e showPasswordIconWhenFocus (or a more concise name if you can think of one)
Hey @scottyab - I'm finding that even on the master branch, the show-hide functionality isn't working in most of the sample edit texts, i.e. there is text in the edit text, it is shown in the dotted form, and tapping the eye symbol doesn't change it to clear text. It only works in the TextInputLayout.
I had a problem with the gradle version having expired (from using a beta). I've tried with 2.0.0 (the closest version to the beta used) and 2.1.2 (current version), but neither of them fix the problem.
Do you have any thoughts about why this is? I can send you a screen capture of the issue if that would help.
Hmm ok, sounds strange. A video would help more than screen grabs. Thanks
On Tue, 14 Jun 2016, 05:40 Alix, [email protected] wrote:
Hey @scottyab https://github.com/scottyab - I'm finding that even on the master branch, the show-hide functionality isn't working in most of the sample edit texts, i.e. there is text in the edit text, it is shown in the dotted form, and tapping the eye symbol doesn't change it to clear text. It only works in the TextInputLayout.
I had a problem with the gradle version having expired (from using a beta). I've tried with 2.0.0 (the closest version to the beta used) and 2.1.2 (current version), but neither of them fix the problem.
Do you have any thoughts about why this is? I can send you a screen capture of the issue if that would help.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/scottyab/showhidepasswordedittext/issues/19#issuecomment-225778373, or mute the thread https://github.com/notifications/unsubscribe/AAYqiSCgeEwmkce2kZbc2zhZ-joAmykjks5qLjDKgaJpZM4I0AKj .
Ahh I see you're encountering the same problem. Here's the link to a video of it anyway: https://drive.google.com/open?id=0B4dWTi2C0bQLY0d5VW1qZHJnYzg
I can still submit a PR for the work to show focus if you like - as I'm using the TextInputLayout version which still works, I can verify that it's working correctly in there.
Yes. Thanks I'll take a look at the other focus issue separately in couple days when I have time. (that is if someone does figure it out beforehand)
On Tue, 14 Jun 2016, 22:04 Alix, [email protected] wrote:
I can still submit a PR for the work to show focus if you like - as I'm using the TextInputLayout version which still works, I can verify that it's working correctly in there.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/scottyab/showhidepasswordedittext/issues/19#issuecomment-226015701, or mute the thread https://github.com/notifications/unsubscribe/AAYqiQMTD0t50lZKZ1cTW3c56DeHGNxCks5qLxdIgaJpZM4I0AKj .
It seems that the issue is that the touch target is tiny and in the top right corner - perhaps the same issue as https://github.com/scottyab/showhidepasswordedittext/issues/16.
@evolutionise I've fixed the issue of the tiny touch target and added a new attribute app:additionalTouchTargetSize if you want to make it bigger