Scott Alexander-Bown

Results 87 comments of Scott Alexander-Bown

Thanks for flagging this @robsmall , in progress

Hey @robsmall I was looking for a open source nodeJS, PHP, ruby (or any web language really) server implementation that I could either link to or include in this repo....

@khalid64927 thanks for commenting. If i understand your question... you're after client side parsing/reading and validation? This is exactly what safetynethelper does, maybe I need to make the readme.md clearer....

Arrh ok, i'm with you. I would of thought only Google can verify the request came from Google? That's the point of that Google Verification API? maybe i'm missing something.

Hey @ljcleyba I'm not seen that before. Is there a chance it's running on a device without the Google Play services?

I've updated the lib and the sample app in the playstore to use the latest version of safetyNet. Once the updated .apk has perticulated to your parts of the world...

@sudansh The cc-test-reporter tool supports summing the coverage files from multi repositories. We have 3 modules /app /api and /data. We call `format-coverage` for each of the `jacoco.xml` report files...

Hmmm... potentially this issue is on Drone or my setup of it. Seems `DRONE_PULL_REQUEST` is not being set, if hardcode the DRONE_PULL_REQUEST env var, danger will run aok. ``` environment...

Thanks @orta from the [docs](https://docs.drone.io/pipeline/environment/reference/drone-pull-request/) it seems `DRONE_PULL_REQUEST` is still valid, so I guess this must be more of a local issue with our setup? As mentioned above if hardcode...