Added support for receiving HTML input and bug fix

Open advance512 opened this issue 5 years ago • 1 comments

Added support for receiving HTML input Fixed issue with dimensions(tag) not working for some websites

Jun 17 '20 20:06 advance512

I am not sure why the Travis CI is not showing up in gitlab checks but there are some errorshttps://travis-ci.org/github/scottwernervt/favicon/builds/699454421.

The py27 test is failing so I think we might have to move html_override arg in front of *args.

Unfortunately we can't do that, as that will mean that code like this:

favicon.get('http://mock.com/', headers)

will see the headers as the html parameter and break. Putting the html parameter after the args* means it becomes a keyword only argument, which solves it. Alternatively, we can modify the version to show non-comaptibility, or drop Python 2.x support (it is EOL'd after all).

Jun 18 '20 09:06 advance512