Scott Rigby

Results 89 comments of Scott Rigby

Note there may be a need to clarify RBAC best practices. See https://github.com/helm/charts/pull/6407#pullrequestreview-149020512 and https://github.com/helm/charts/pull/6407#issuecomment-415497659. Will need to ask @viglesiasce about thoughts on how to clarify.

Question maybe for our next chat… what about best practices for HPAs? It seems only `stable/spark` and `stable/nginx-ingress` define a `HorizontalPodAutoscaler` in templates (`stable/dask-distributed` has a reference to `worker.replicasMax` in...

@paulczar ^ I updated the description to add helm/charts#7562

Re Affinity / anti-affinity, there's a note added in helm/charts#3334, does someone want to add an example (perhaps draw from `redis-ha` [values](https://github.com/helm/charts/blob/master/stable/redis-ha/values.yaml#L18-L24) and [deployment template](https://github.com/helm/charts/blob/master/stable/redis-ha/templates/redis-server-deployment.yaml#L30-L52))?

I added `PodSecurityPolicy` to the list @paulczar

@davidkarlsen Good question - there's a short note about PDB in the REVIEW_GUIDELINES, with a link to the docs (from helm/charts#3334): >It is recommended that Deployments and StatefulSets configure their...

Per office hours Today, we need to address changing labels. Noting here because we will also want to ensure the best practices around this are documented. - @davidkarlsen added this...

> @scottrigby Since these updates are to a _blog post_ not to docs specifically, please decide how you want to handle this - thanks. I brought this PR's commit into...

Agree with @todaywasawesome. The scope of this WG is concerned with patterns, definitions, criteria, and practices. Tools should work to implement these, not the other way around. @alanjcastonguay that said,...