Change MAXNUMONOFF

[matteobachetti]

Hi @scottransom, is there a specific reason why MAXNUMONOFF is hardcoded to 40?

For X-ray data from some missions, it would be very helpful to increase it, so that we can exclude from the analysis all the frequent gaps due to telemetry and orbital occultation, SAA passages, etc, and get more consistent statistics.

(I'm tagging here also @ferrigno)

[scottransom]

Nope, not at all. Actually, the ON/OFF pairs are something that I think is rarely if ever used in PRESTO. If you use it, I'd happily accept a patch to make that dynamic (or have a higher fixed number).

[tanumanghosh]

Hi, @scottransom, and @matteobachetti, was this issue resolved? Is it possible to change the number for MAXNUMONOFF in the current PRESTO version?

[scottransom]

@tanumanghosh I haven't touched this in PRESTO. I suspect that you could change the MAXNUMONOFF in the code (in include/makeinf.h) without issue. But the issue is that it really doesn't do much (if anything) for actual processing. The only use I've ever made of it (and that was rare) was with the window program which shows what your Fourier response function would look like given a window function based on the ONOFF pairs. But that isn't even used for anything except display purposes. So I'l probably just recommend not using ONOFF pairs at all.