presto icon indicating copy to clipboard operation
presto copied to clipboard

Published 20 hours ago • verified publisher icon scottransom

Change MAXNUMONOFF

Open matteobachetti opened this issue 2 years ago • 1 comments

Resolve #77

matteobachetti avatar May 30 '22 07:05 matteobachetti

@matteobachetti Sorry about the delay on this. I must have missed the notification when you did that.

I think it would be OK to increase MAXNUMONOFF fairly substantially, but I'm not willing to many millions, as you have it here. The reason is that in makeinf.h the INFODATA structure has a static size which includes a double precision array of:

double onoff[MAXNUMONOFF*2];

So that means each INFODATA structure would be over 6GB in size!

The proper way to do this would be to make INFODATA dynamically sized, but that greatly complicates things -- especially passing those structures to/from Python.

scottransom avatar Dec 21 '22 16:12 scottransom