animator-video-reference icon indicating copy to clipboard operation
animator-video-reference copied to clipboard

Method of temp folder usage is potentially unsafe

Open KnowZero opened this issue 4 years ago • 0 comments

There are 2 problems with the temporary images folder based on current implementation.

  1. If an images folder already exists in the current directory, that images folder will be deleted and you will lose all your images

Suggestion is to use a more custom naming scheme such as: ".animator-video-reference-temp"

  1. In the event of a crash, the old images are left in the undeleted folder, and running a different video can lead to more crashes (probably due to difference in image size)

Suggestion is to check for the temp image folder on run and removing it.

KnowZero avatar Nov 10 '20 17:11 KnowZero