Scott Lamb

Results 309 comments of Scott Lamb

Thanks! The code looks correct to me. Could you throw in a test and a "BREAKING CHANGE:" entry in `CHANGELOG.md`?

The main reason I'm excited about this is because I'm running on CI, and all my mtimes change with each run, so my valid cache contents are never used. I...

> These cameras seem particularly broken to me, do they expect clients to send multiple SETUP requests, and is that even allowed? One per track of interest is normal (video...

That's not consistent with my understanding of the spec. For one, the following excerpt doesn't make sense to me if there can be 1 bits following the `rbsp_trailing_bits`. > more_rbsp_data(...

fwiw, I'm definitely of two minds about accepting crappy input in general: * There's a lot of bad code/data that's out there that's not easy to change, and it's useful...

Ouch! When starting a fragmentation unit, `h265::Depacketizer::push` puts in a placeholder `next_piece_idx`. (Really, I should change it to be explicit about this via `Option` instead; 0 isn't a valid value...

You called `Demuxed::poll_next` and got `Some(Err(_))`. So far, this is by design. Then you called it again. What were you hoping would happen? Obviously not a panic, and that's a...

Care to give the `fix-122` branch a spin?

I believe there's another interface that requires less parsing, described [here](https://docs.kernel.org/admin-guide/mm/transhuge.html): > Some userspace (such as a test program, or an optimized memory allocation library) may want to know the...