Respond icon indicating copy to clipboard operation
Respond copied to clipboard

Added support for min-height and max-height media queries

Open danielcrisp opened this issue 11 years ago • 11 comments

I needed min-height / max-height support for a project I am working on.

I found this pull request but it was from an old version, so I used the same technique to add min/max-height support to the latest version

https://github.com/scottjehl/Respond/pull/96

danielcrisp avatar Dec 05 '13 12:12 danielcrisp

This is awesome. Any chance you wanna write some tests for this as well?

jefflembeck avatar Dec 06 '13 17:12 jefflembeck

There is a basic HTML test in this file: https://github.com/danielcrisp/Respond/blob/master/test/test.html

If you resize the browser height you should see the typeface change from sans-serif to serif

danielcrisp avatar Dec 06 '13 18:12 danielcrisp

Also excluding a stylesheet should be removed from this branch. Did you delete your comment or is Github getting confused?!

danielcrisp avatar Dec 06 '13 18:12 danielcrisp

Ha, left that comment before going down a few commits and seeing the deletion! :D Sorry about that.

jefflembeck avatar Dec 06 '13 18:12 jefflembeck

I actually meant unit tests. We currently have a suite of them for width checks.

jefflembeck avatar Dec 06 '13 18:12 jefflembeck

I was worried you meant unit tests!

Haven't really got time for that at the moment... probably won't be able to do that until the new year. Can it wait?

danielcrisp avatar Dec 06 '13 18:12 danielcrisp

+1 sterling work so far!!

sidonaldson avatar Jan 08 '14 10:01 sidonaldson

+1 whould be great if this one could be merged!

eirslett avatar Feb 07 '14 19:02 eirslett

+1

ainformatico avatar Apr 02 '14 16:04 ainformatico

What's the holdup on this?

TechFounder avatar Jul 30 '14 21:07 TechFounder

I realize this is ancient at this point, but I'm needing to support IE8 for something (I know, I know), and needing this. Could someone review the conflict and merge? IMHO this should be standard issue.

albell avatar May 23 '16 17:05 albell