d3-book icon indicating copy to clipboard operation
d3-book copied to clipboard

Published 20 hours ago • verified publisher icon scotthmurray

Fixed multiple tips being displayed during sort

Open sfavorite opened this issue 5 years ago • 2 comments

Using selectAll should remove extra tool tips created when a sort is running. I attached a picture of my after a sort.

Screenshot from 2019-12-07 07-49-37

sfavorite avatar Dec 07 '19 21:12 sfavorite

Thanks @sfavorite! I have no immediate plans to update the master branch here, unless I were to update the book, to prevent confusion for readers. I'm going to leave this PR open and if and when I do an update, I will be sure to incorporate your contribution (and update the book text accordingly). Thanks!

scotthmurray avatar Dec 08 '19 21:12 scotthmurray

I completely understand, Mr. Murray. Thank you for the consideration.

I have learned a lot from the book and am using D3 v5 and only a couple of changes have been needed to deal with promises - at least as far as chapter 11. Thanks again!

sfavorite avatar Dec 08 '19 22:12 sfavorite