Generated build number doesn't appear to be included in resulting assembly version (but revision is)

[davidfishlock]

trafficstars

Hi Scott, Firstly thankyou for this great tooling, I think it is really going to help simplify our build process.

Not sure if this is a bug, or perhaps a misunderstanding on my part.

I have a version.props containing the following

  <PropertyGroup>
    <VersionMajor>2</VersionMajor>
    <VersionMinor>3</VersionMinor>
  </PropertyGroup>

When I call dotnet build build/Cadru.VersionUpdate.targets -t:UpdateAssemblyVersionInfo it seems to generate both Revision and Build numbers in the build.props.

  <PropertyGroup>
    <BuildDate>16/01/2024 15:28:11 +00:00</BuildDate>
    <VersionBuild>24066</VersionBuild>
    <VersionRevision>34445</VersionRevision>
  </PropertyGroup>

But when I build the solution, the assemblies are ending up with version 2.3.0.34445, so it seems VersionRevision is being applied, but VersionBuild isn't for some reason.

I don't think I've really changed anything that would impact this, am I missing some configuration here?

[davidfishlock]

In summary, looks like there are discrepancies around the terminology of VersionBuild and VersionPatch used in this repo.

Amending some of the configuration files to use VersionBuild instead seems to have fixed this.