dool icon indicating copy to clipboard operation
dool copied to clipboard

Published 20 hours ago • verified publisher icon scottchiefbaker

Catch OverflowError

Open jkleckner opened this issue 3 years ago • 3 comments

ISSUE TYPE
  • Bugfix pull-request
DSTAT VERSION
Dool 1.0.0
SUMMARY

This is an application of the patch to dstat described here:

  • https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619/comments/5

jkleckner avatar Nov 27 '21 17:11 jkleckner

Rebased to master.

jkleckner avatar Jan 23 '22 18:01 jkleckner

Rebased to master

jkleckner avatar Jul 02 '22 19:07 jkleckner

Rebased again. Is this patch of any interest?

jkleckner avatar Sep 04 '22 19:09 jkleckner

Apologies... Github was not sending me alerts for issues and pull requests on this repo. I did not see this until just now.

Is this still relevant? I'm working through some backlog.

scottchiefbaker avatar Jun 03 '23 02:06 scottchiefbaker

Yes, this is still relevant.

SuperTux88 avatar Jun 03 '23 22:06 SuperTux88

Rebased again.

jkleckner avatar Jun 04 '23 04:06 jkleckner

I use this with the patch and it is necessary for me.

jkleckner avatar Jun 04 '23 04:06 jkleckner

Before I merge this I need a little more information. What overflow is this catching, and how is it triggered?

scottchiefbaker avatar Jun 04 '23 21:06 scottchiefbaker

This bug report details the disk IO overflow pretty well:

https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619

jkleckner avatar Jun 05 '23 14:06 jkleckner

It also crashes sometimes when adding/removing network interfaces (connecting/disconnecting VPN).

SuperTux88 avatar Jun 05 '23 15:06 SuperTux88

Does this address the random "OverflowError: cannot convert float infinity to integer" from #3?

scottchiefbaker avatar Jun 05 '23 15:06 scottchiefbaker

Does this address the random "OverflowError: cannot convert float infinity to integer" from #3?

Probably, yes.

jkleckner avatar Jun 05 '23 20:06 jkleckner

@jkleckner EXCELLENT. That has been one of my personal pet peeves for 12+ months now.

scottchiefbaker avatar Jun 05 '23 21:06 scottchiefbaker