Scott Barnes

Results 137 comments of Scott Barnes

For my part, I am not convinced we can, with confidence, get from the ISBN to the correct publisher. But I do agree that low quality imports should not overwrite...

I see that `IA-NS-0000662` is listed as one of the pallets at https://archive.org/details/bwb_daily_pallets_2021-01-26, so there seems to be at least some connection. I am unsure of how the exact pallet...

Pending a way to confidently add publisher records from the ISBN prefix, I am going to close this as not (currently) planned.

@bradyguyc, the endpoint mek mentioned works with cookies and is probably best suited to one off imports, so if you just have a small list to import, that may be...

Some additional information: for the first book, the cover, `14627720-L.jpg`, seems to be missing from https://ia600505.us.archive.org/view_archive.php?archive=/35/items/l_covers_0014/l_covers_0014_62.zip.

This likely comes from #10313. We'll need to update the hosts and also we should probably add logger with something like `logger = logging.getLogger('openlibrary.catalog.add_book')` and then `logger.warn(f"Removing cover: host {host}"...

@hornc, I added a new commit, c55bb6afd7a182d5975973cf2f34eaad758fb783, that is hopefully responsive to the request to make the tests more explicit not just in terms of how they're named, but how...

@hornc, I just wanted to follow up to see if this [latest commit](https://github.com/internetarchive/openlibrary/pull/9753/commits/3eb49037dec7e54aa88608d7304faba6008ecdea) is headed in the direction you envisioned.

I went ahead and merged this, just so we can have tests to work off of as we make these requirements less stringent, per #10157.

@schu96, you may need `/usergroup/librarians` privileges also. I am unsure whether it's better to update the code that checks the permissions so the merge button only displays when someone has...