mocha.el
mocha.el copied to clipboard
Update and fix failing tests, identify Mocha globals, and cleanup readme
This PR is a combination of commits I prepared locally before an attempt to push revealed master
is a protected branch. 😓 The changes are atomic and (hopefully) self-explanatory, but in short, they
- Update the versions of Node and Mocha used to run the tests
- Fix the currently-broken status badges in the readme
- Identify Mocha's globals to
js2-mode
so functions likedescribe()
andit()
aren't flagged as errors - Improve the makefile's overall user-friendliness by:
- Only installing project dependencies when they don't exist
- Not assuming that an
$NPM
variable set in one's environment points to thenpm(1)
binary; I have$NPM
set to/usr/local/lib/node_modules
, so runningmake
quickly failed.
Note that it's still possible to override variables on a case-by-case basis like this:$ make NPM=/path/to/npm CASK=/path/to/cask install
I'll endeavour to keep future maintenance a little more review-friendly. 😉
/cc @scottaj
Nudging @scottaj for an update.