Scott Andrews

Results 57 comments of Scott Andrews

Even if you only need the name field. I'd recommend using a [LocalObjectReference](https://pkg.go.dev/k8s.io/api/core/v1#LocalObjectReference)-like struct. The key advantage is that it's more clearly a reference and it's much easier to introduce...

> Fundamental design issues? Not so much an issue but an open question around the shape of snippets as [started by](https://github.com/vmware-tanzu/cartographer/pull/72#issuecomment-1036604300) @jwntrs, and [then continued](https://github.com/vmware-tanzu/cartographer/pull/72#discussion_r814877328) by me.

The apps cli today will [query Knative Services that match a label](https://github.com/vmware-tanzu/apps-cli-plugin/blob/0e1524fbf625e55a9208c714c97ad3f169494762/pkg/commands/workload_get.go#L140), the URL is then read from the status of those resources. If there are no Knative Services, or...

> There is no workload on the runtime cluster so no `workload.status` to inspect for the URL. > For env's where there _is_ a workload, can cartographer provide the URL...

This is an unpopular opinion, but depending on foreign types and clients for k8s resources is ["considered harmful"](https://meyerweb.com/eric/comment/chech.html). There are frequent (about once a year) upstream api breakages in k8s...

>I think this rfc is important in it's ability to provide defaultable fields. That's a compelling distinction as it is not possible with a vanilla field selector operating against the...

> 3. hack hack scripts sed/awk the go.mod file for the version to use ``` go mod download -json | jq -r 'select(.Path == "k8s.io/api").Version' ```

I first saw this pattern in kpack. It basically involves setting up a fake GOPATH for gengo https://github.com/pivotal/kpack/blob/master/hack/update-codegen.sh#L16-L18

While I understand and appreciate the desire, this behavior will make installing and using kpack more fought. [Level based triggering](https://hackernoon.com/level-triggering-and-reconciliation-in-kubernetes-1f17fe30333d) is fundamental to Kubernetes controllers and it's worth taking the...