zipstreamer icon indicating copy to clipboard operation
zipstreamer copied to clipboard

Resolved: "// TODO: flush after every 32kb instead of every file to r…

Open jtrinh27 opened this issue 2 years ago • 2 comments

flush after every 32kb instead of every file to reduce memory

jtrinh27 avatar Mar 06 '22 17:03 jtrinh27

@scosman Could you please get this merged? Thank you

skrivy avatar May 24 '22 11:05 skrivy

Ok. I can see that related project has been taken down and this pull request is still open.

skrivy avatar Jul 19 '22 20:07 skrivy

Thanks for the patch!

io.Copy apparently already does use a 32KB buffer (strange it's the exact amount from my comment, but I'll take it).

Closing since this is not needed. I'll clean up the comment.

https://cs.opensource.google/go/go/+/refs/tags/go1.19.2:src/io/io.go;l=385

scosman avatar Oct 26 '22 15:10 scosman