kute icon indicating copy to clipboard operation
kute copied to clipboard

ImageRequest function is Volley library is deprecated!

Open CloudyPadmal opened this issue 7 years ago • 6 comments

Issue

The image request call made to fetch images from URL is deprecated. Picasso is a library specialized in image fetching compared to Volley. We can integrate that library instead of Volley as volley hasn't been use anywhere in the app except for image fetching

Steps to reproduce

  1. Go to RegisterActivity class
  2. Find "ImageRequest"

Would you like to work on this issue?

Yes and I can send a PR for review!

CloudyPadmal avatar Mar 30 '17 03:03 CloudyPadmal

@CloudyPadmal brother you can use image loader as well...using the same volley library..

icancode23 avatar Mar 30 '17 03:03 icancode23

@icancode23 agreed! But picasso is simple to integrate than volley! Don't you agree? :)

CloudyPadmal avatar Mar 30 '17 03:03 CloudyPadmal

@CloudyPadmal no i was just saying that because then you won't need an additional dependency of picasso

icancode23 avatar Mar 30 '17 04:03 icancode23

@icancode23 volley is only used in this image fetching. So instead of that we can use Picasso, a library specialized in image fetching from URLs to simplify the code!!

CloudyPadmal avatar Mar 30 '17 04:03 CloudyPadmal

@CloudyPadmal two developers..two different thinking....

icancode23 avatar Mar 30 '17 04:03 icancode23

That's good for app development! :)

CloudyPadmal avatar Mar 30 '17 05:03 CloudyPadmal