fact-bounty icon indicating copy to clipboard operation
fact-bounty copied to clipboard

Add profile page + components + adjustments

Open JosephSemrai opened this issue 5 years ago • 5 comments

Please provide enough information so that others can review your pull request:

Related to issue: #458 (Google Code-in Task)

  • Add /profile route which renders the Profile component
  • Add UserInfo component to be used in the profile page
  • Create profile page

Test plan (required)

Tests succeed. UI

Code formatting Ran format script (prettier using the provided config)

Closing issues Did not mention closing issue here as I am not 100% sure that this directly involves that issue.

JosephSemrai avatar Dec 28 '19 17:12 JosephSemrai

@JosephSemrai 2 simple codacy issues are there. Fix them and commit and also squash all commits to a single one.

root5533 avatar Dec 28 '19 19:12 root5533

I have tried multiple methods of adding the line endings, including methods for both types of line endings, yet Codacy will still not recognize the changes. Does anyone have any insight on this? It would be greatly appreciated.

JosephSemrai avatar Dec 30 '19 04:12 JosephSemrai

It appears that rebasing the commits is causing Codacy to not detect the line endings.

JosephSemrai avatar Jan 02 '20 17:01 JosephSemrai

@Anmolbansal1 Whenever I rebase the commits and push it back to the remote, Codacy complains about there not being a trailing line ending, even though there is one. Do you happen to know how I might fix this or if there may be something in Codacy's configuration to address this?

JosephSemrai avatar Jan 20 '20 04:01 JosephSemrai

It seems that Codacy is complaining about the line endings even though they aren't rebased. I will take a look at this.

JosephSemrai avatar Jan 22 '20 05:01 JosephSemrai