Bassa icon indicating copy to clipboard operation
Bassa copied to clipboard

Get backend URL from env

Open kmehant opened this issue 4 years ago • 10 comments

Signed-off-by: K mehant [email protected]

kmehant avatar Aug 03 '20 16:08 kmehant

Hey @kmehant,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d9885a90-d5aa-11ea-8ca9-c37e1b84d109

TravisBuddy avatar Aug 03 '20 17:08 TravisBuddy

Travis tests have failed

Hey @kmehant, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker build -f ui/Dockerfile.dev -t scoreucsc/bassa-ui:dev ui >/dev/null
The command '/bin/sh -c apt-get update &&     npm install &&     npm install --global bower gulp-cli &&     bower --allow-root install' returned a non-zero code: 1
TravisBuddy Request Identifier: f0ac3040-d5fd-11ea-8ca9-c37e1b84d109

TravisBuddy avatar Aug 04 '20 02:08 TravisBuddy

Use environment variable apiUrl to set Bassa API url

kmehant avatar Aug 04 '20 03:08 kmehant

Hey @kmehant,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0bb5a100-d603-11ea-8ca9-c37e1b84d109

TravisBuddy avatar Aug 04 '20 03:08 TravisBuddy

Hey @kmehant,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 53767e70-d625-11ea-8693-3322afd57804

TravisBuddy avatar Aug 04 '20 07:08 TravisBuddy

Screenshot from 2020-08-04 15-39-19

Try this method.

See https://hub.docker.com/_/nginx

COPY the env.js.template to /etc/nginx/templates with placeholder

agentmilindu avatar Aug 04 '20 10:08 agentmilindu

Hey @kmehant,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 9b4213c0-d717-11ea-85fc-4b61cecd2c91

TravisBuddy avatar Aug 05 '20 12:08 TravisBuddy

Hey @kmehant,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 2beb4f90-d718-11ea-85fc-4b61cecd2c91

TravisBuddy avatar Aug 05 '20 12:08 TravisBuddy

@agentmilindu I have tested it now, it works well having apiUrl set for server URL is taking up the changes in run time on reloading the container.

But all server routes give out 404 because of this PR https://github.com/scorelab/Bassa/pull/890 which does not seem to work with WSGI and supervisord layers well. Works without WSGI and supervisord though.

kmehant avatar Aug 05 '20 12:08 kmehant

Screenshot from 2020-08-04 15-39-19

Try this method.

See https://hub.docker.com/_/nginx

COPY the env.js.template to /etc/nginx/templates with placeholder

Are you planning to have bassa server also routed through the same nginx 🤔, then how about mounting the nginx config with an another server block for Bassa server?

kmehant avatar Aug 05 '20 12:08 kmehant