Bassa icon indicating copy to clipboard operation
Bassa copied to clipboard

Bassa uses localhost URL's, instead use IP address of localhost

Open vivonk opened this issue 7 years ago • 6 comments

Feature bug

Expected Behavior

Currently, when someone will use Bassa for the enterprise then localhost will be redundant because most of the requests use localhost.

Current Behavior

Someone on the same network can't access Bassa server for any activity because browser makes requests to localhost which is itself.

Possible Solution

Instead of making localhost requests, use Bassa server-setup IP address or define config file for doing this.

Steps to Reproduce (for bugs)

  1. Make a config file for every run
  2. Use localhost for development and IP address on production
  3. Improve all existing API's for above strategy
  4. Change unit tests accordingly

Your Environment

  • Version used: v 0.0.1

vivonk avatar May 29 '18 10:05 vivonk

@agentmilindu @rehrumesh @malithsen what you think about this?

vivonk avatar May 29 '18 10:05 vivonk

@vivonk Yes, server IP/domain should come from a config.

agentmilindu avatar Oct 07 '18 18:10 agentmilindu

@vivonk Can you add this as a GCI task?

agentmilindu avatar Oct 07 '18 18:10 agentmilindu

I am reopening this issue as this also has to be done for deployments so we have to implement it before release :) @kmehant

vivonk avatar Jun 05 '19 05:06 vivonk

@vivonk I will take up this issue :)

kmehant avatar Jun 05 '19 13:06 kmehant

Ok sure @kmehant :)

vivonk avatar Jun 05 '19 19:06 vivonk