Ville Skyttä
Ville Skyttä
Also, incremental decoding instead of `read()` slurp would be nicer. Can polish once we establish this will be accepted in the first place.
From https://github.com/pre-commit/pre-commit-hooks/issues/683#issuecomment-970279641 > any decent programming language already presents encoding issues as syntax errors so I'm not sure where it would be useful Sadly, not all developers run test suites...
Some counterarguments: - No problem changing the default, UTF-8 probably is the better choice. - We can forget about the #683 considerations, and people who know what they're doing can...
Yes, string is easy, and the linked tests deal with strings. But distinguishing between `number` and `integer` within formats is not always possible with the current setup. If I'm missing...
Unfortunately `strconv.ParseInt` and a few other things that operate on ints are not usable for this purpose, because they fail the `.0` fraction part case. Anyway I take that comment...
I submitted this for a reason ;). I'm using this particular library with OpenAPI, because no OpenAPI lib that I've found comes close to what I like to see. It's...
I implemented a fix for this before noticing this PR. However I don't think the implementation here is correct -- I believe it would not work appropriately when `filter_post_data_parameters` or...
I am very confident that this is the right thing to do. If not done, the request body of a POST that results in a redirect is recorded as `null`....
Anything more I can do to help getting this merged?