bash-completion
bash-completion copied to clipboard
scop
curl: fix option listing in newer versions
_parse_help only takes a single parameter (which is then splits) for the options that it invokes the tool with, so curl was being invoked with just --help, not with --help all.
The test failure seems unrelated, is there something else I should do here?
Rebasing should fix the test failure.
With regards to what to do here, I'd like to see a test suite addition for this. Basically one for which we'd check that an option that is only output with --help all but is common enough to be available in ~all curl is emitted as a completion. For example curl --data-binar and then check that --data-binary is with suggested completions. This would be done in test/t/test_curl.py, and it would be a require_cmd=True one.
Additionally, we've adopted conventional commits comment message conventions recently, and starting from next version it's important we follow that, because it has direct effect on change log and bash-completion version generation. So rewording while rebasing suggested, let's say fix(curl): --help all parsing would be an appropriate first line, the rest of your current commit message is great as is.
I need this change before performing the interface change of _parse_help.
