lvm: improve completions for `lvremove`

Open siteshwar opened this issue 10 months ago • 4 comments

It should have a completion for /dev/mapper path.

Feb 18 '25 16:02 siteshwar

This is a fix for https://bugzilla.redhat.com/show_bug.cgi?id=2317249.

You can test it by running lvremove /d<TAB>.

Feb 18 '25 16:02 siteshwar

I think we can add a test for /dev/mapper/.

Mar 03 '25 11:03 akinomyoga

I fixed the commit message to follow Conventional Commits and added a test.

Mar 03 '25 13:03 akinomyoga

When I run complete on lvremove /dev/ma, it gets completed to lvremove /dev/mapper/ with a space at the end, which doesn't really make sense, since you will want to continue filling that in with the actual devices there. I'm not sure what will be a better way though

Mar 03 '25 21:03 yedayak