Scott Olsen

This commit simplifies and updates our model for locations of interest: - We retain only a single LocationOfInterest data class that accepts a geometry in its constructor. - The Builder...

we have a few instances in the code base in which we pass primitive types that have additional meaning e.g. passing entity IDs as `String` (not technically a primitive but...

[Docs] Document issue creation process

1

Once we've determined the best process for creating new issues, we should document it in CONTRIBUTING.md (On the issues page, a message from github recommends reading this file prior to...

[Code Health] Simplify View Models

2

There are a number of TODOs lying around regarding VM simplification. We should address these! Creating an issue so that we can reference it in each TODO. @gino-m

fix: show deletion mutations in sync status UI

1

Before, we cascaded deletions on the foreign keys for feature/observation mutations, meaning all mutations for a feature/observation were wiped from the DB, eradicating the user's edit/sync history. This change alters...

OfflineBaseMaps: Exception android.os.NetworkOnMainThreadException

6

Apparently we're executing network instructions on the main thread. Weirdly enough, this exception never occurred when I committed the recent networking changes to offline basemaps...but now it does.

Includes minor grammatical changes and embellishments that might make the docs a bit easier to use for newcomers.

threat -> treat

Kotlin has nice native support for declaring singletons using `object` declarations. Unfortunately, Dagger does not support injecting classes into `objects`, which at the moment pretty much prevents us from using...

[Code health] Consistent naming of local DB converters

16

Pretty much every local db entity has to/from conversion methods for converting a corresponding model object to the local db entity type. However, we don't name these consistently. Sometimes they...