seyren icon indicating copy to clipboard operation
seyren copied to clipboard

Add Amazon Web Services (AWS) SNS Support

Open mazurio opened this issue 9 years ago • 9 comments

  • Added as discussed in https://github.com/scobal/seyren/issues/331
  • Supports AWS Lambda through SNS
  • Supports SMS through SNS
  • Uses default AWS credentials
  • Supports AWS Regions from SNS_REGION config.
  • Target is an ARN of the SNS Topic.

mazurio avatar Oct 22 '16 18:10 mazurio

@scobal let me know what you think and whether this could make the next release. Thanks.

mazurio avatar Oct 22 '16 18:10 mazurio

Testing:

screen shot 2016-10-22 at 19 48 03

mazurio avatar Oct 22 '16 18:10 mazurio

Looks great... Have you thought about adding a link back to the Seyren Check in the msg... something like: String checkUrl = seyrenConfig.getBaseUrl() + "/#/checks/" + check.getId();

TyBrown avatar Oct 22 '16 21:10 TyBrown

@TyBrown I thought about it - we use SNS to send SMS and Seyren is not accessible from the phone unfortunately. Do you think it would be useful here @TyBrown ?

mazurio avatar Oct 22 '16 21:10 mazurio

@mazurio Given your particular use case, it might be prudent to add a configuration option that would allow the URL to be inserted or left out... As you know, SNS is very flexible, and can be used to forward messages to many different destinations, many of which I can see a high use case for having a link to the check. I can figure out the implementation details if you don't want to work on that part of it, though figured you already have a PR open... up to you. :)

TyBrown avatar Oct 22 '16 21:10 TyBrown

Makes sense :) I will add it tomorrow as it's quite late here already - unless you want to add it first then feel free to do so!

mazurio avatar Oct 22 '16 22:10 mazurio

@TyBrown @scobal Pushed checkUrl to SNS. It will now print something like:

Seyren notification 'Test' changed state to 'ERROR' http://localhost:8080/seyren/#/checks/580c93a8124350039a163b32

mazurio avatar Oct 23 '16 10:10 mazurio

@mazurio LGTM! :)

TyBrown avatar Oct 23 '16 19:10 TyBrown

@alenkacz any update on this? Looks like it was good to merge last year?

Mousius avatar Jul 19 '17 09:07 Mousius