seyren icon indicating copy to clipboard operation
seyren copied to clipboard

Hipchat notifications failed if room name contains spaces

Open b-viguier opened this issue 8 years ago • 0 comments

Hello, Since the migration to Hipchat API v2, the room id is contained in the URL, and must be url-encoded (you can check corresponding documentation here. Unfortunately, the hipchat notification service does not: https://github.com/scobal/seyren/blob/e40cdd0bf887ab1ca496fa9ca1772462c91cf263/seyren-core/src/main/java/com/seyren/core/service/notification/HipChatNotificationService.java#L89

Workaraound: As a Seyren user, you can rename your room, or use the numerical id of the room… but if you have lot of checks to update it may be painful 😢

Thanks for your work! Benoit

b-viguier avatar Sep 14 '16 08:09 b-viguier