react-codemirror2 icon indicating copy to clipboard operation
react-codemirror2 copied to clipboard

Cannot upgrade react to 17 thanks to npm complaining that react-codemirror2 supports react 16 only

Open vass-david opened this issue 3 years ago • 7 comments

Hi!

I can see that react version in this repo is correct (up to 17.x), but for some reason my npm complains that it's only up to 16.x. Any idea what went wrong? I've tried cleaning my npm cache, but it didn't help (I didn't expect it will anyway). Might it be that current version published in npm has an outdated package.json?

Thanks!

vass-david avatar Jan 27 '22 12:01 vass-david

The latest release (https://github.com/scniro/react-codemirror2/tree/7.1.0) has the following in the package.json file :

https://github.com/scniro/react-codemirror2/blob/cc3a47d0707b060bf1a1e42ccb258b9b7c0882fd/package.json#L56

I think the reason is that npm is reading the peer dependancy of 16.x and enforcing that. Latest version on npm seems to be 7.2.1 and that also has the same 16.x upper restriction.

MikeHingley22 avatar Mar 02 '22 00:03 MikeHingley22

The latest release (https://github.com/scniro/react-codemirror2/tree/7.1.0) has the following in the package.json file :

https://github.com/scniro/react-codemirror2/blob/cc3a47d0707b060bf1a1e42ccb258b9b7c0882fd/package.json#L56

I think the reason is that npm is reading the peer dependancy of 16.x and enforcing that. Latest version on npm seems to be 7.2.1 and that also has the same 16.x upper restriction.

i see that last release was back on 2020. Any word on when is the next one?

AlexCriollo avatar Mar 14 '22 19:03 AlexCriollo

ping

iiiusky avatar Mar 17 '22 08:03 iiiusky

@elsigh @ihollander @fongandrew @anandsainath @scniro ping

ksathyanm avatar May 16 '22 22:05 ksathyanm

Same for React 18

vldmr1986 avatar May 30 '22 09:05 vldmr1986

Ended up copying index.tsx to the project :(

supun-io avatar Jun 26 '22 09:06 supun-io

React 17 support was added under #224, which was published in [email protected]. Super work!

s100 avatar Nov 14 '23 10:11 s100