s2i-ruby-container icon indicating copy to clipboard operation
s2i-ruby-container copied to clipboard

Add ruby 3.1

Open jackorp opened this issue 3 years ago • 15 comments

Disabled for: RHEL7 (won't ship there, maybe it is better to delete the related files?) RHEL8, RHEL9 -- not yet available Fedora: requires s2i-base of at least F36, I could not find such image on quay.io.

Available for: C9S

There is an issue with rails-ex related tests (== from_dockerfile*), other pass: https://gist.github.com/jackorp/0e131fe3b979c48098347ae6380d7df3#file-c9s_ruby31-log-L2036

jackorp avatar Jul 08 '22 14:07 jackorp

@pvalena JFYI

jackorp avatar Jul 08 '22 14:07 jackorp

I have tested only the c9s ... with updated rails-ex app as well.

Let's refresh the Gemfile.lock first, though. https://github.com/sclorg/rails-ex/pull/150

(I'm just testing the final version, it seems.)

pvalena avatar Jul 08 '22 15:07 pvalena

Pre rails-ex refresh -- RHEL-9 seems to be overloaded or broken :).

RHEL-8: ok

RHEL-7: ''Your PostgreSQL is too old. Either install an older version of this gem or''

pvalena avatar Jul 08 '22 16:07 pvalena

post rails-ex refresh:

[test] [test-openshift]

pvalena avatar Jul 08 '22 17:07 pvalena

RHEL9 fails at subscription step because we are using 9.1 as the host for some reason

@phracek We really should not be using pre-release RHEL versions in production

pkubatrh avatar Jul 11 '22 05:07 pkubatrh

RHEL-7: ''Your PostgreSQL is too old. Either install an older version of this gem or''

Not really sure how to remedy this situation. The best bet (if we want to keep running that suite) would be IMHO to restrict the pg gem version to something that works with RHEL 7's PGSQL, which would be probably the gem version 1.2.3 that was there until now.

jackorp avatar Jul 11 '22 07:07 jackorp

@jackorp @pvalena I guess, ruby-3.1 will be available only for RHEL8, RHEL9, and Fedora the other Dockerfiles like Dockerfile, Dockerfile.rhel7 can disappear for version 3.1

phracek avatar Aug 03 '22 08:08 phracek

RHEL9 fails at subscription step because we are using 9.1 as the host for some reason

@phracek We really should not be using pre-release RHEL versions in production

This will be fixed by https://github.com/sclorg/s2i-ruby-container/pull/415

phracek avatar Aug 03 '22 08:08 phracek

[test-all]

phracek avatar Aug 03 '22 09:08 phracek

and Fedora the other Dockerfiles like Dockerfile, Dockerfile.rhel7 can disappear for version 3.1

Ok, thanks for the info. I wasn't sure what to do with them. However, Fedora 36/37 and probably even 38 (at least until upstream releases new Ruby in the Fedora 38 timeframe) have Ruby 3.1 at least as an RPM, so please clarify, is this a decision that the Fedora container won't be supported/shipped even though Ruby is available in the repositories?

Follow up on the deletion of Dockerfiles. Should I also remove the C9S Dockerfile, or is that to be kept?

jackorp avatar Aug 03 '22 10:08 jackorp

Ok, thanks for the info. I wasn't sure what to do with them. However, Fedora 36/37 and probably even 38 (at least until upstream releases new Ruby in the Fedora 38 timeframe) have Ruby 3.1 at least as an RPM, so please clarify, is this a decision that the Fedora container won't be supported/shipped even though Ruby is available in the repositories?

Dockerfile.fedora can be used. Only use FROM quay.io/fedora/s2i-base:36. The latest F37 and F38 are not supported yet for s2i-base-container.

phracek avatar Aug 03 '22 10:08 phracek

Follow up on the deletion of Dockerfiles. Should I also remove the C9S Dockerfile, or is that to be kept?

If CentOS Stream 9 supports ruby-31, then we can use it.

phracek avatar Aug 03 '22 10:08 phracek

can you build and push to quay.io/s2i-ruby/devel:3.1 for testing?

EDIT: No need, I've added it myself.

pvalena avatar Aug 22 '22 13:08 pvalena

I've tested this (c9s) with rails-ex, otherwise LGTM.

pvalena avatar Aug 25 '22 04:08 pvalena

There's quite a few mentions of 3.0

Fixed.

Also added 3.1 to the main README.md, however, it often mentions RHEL/CentOS 7, so I left Ruby 3.0 in those parts there for now.

Not sure what to do with cccp.yml as it lists centos7.

Otherwise, make test OS=c9s VERSIONS="3.0 3.1" passed

jackorp avatar Aug 31 '22 13:08 jackorp

[test-all]

phracek avatar Sep 12 '22 11:09 phracek

I have pushed the devel repo file for RHEL 8 and RHEL 9 as I expect both RHELs to have Ruby 3.1 in some devel repo. However, I am not sure if the "devel repo" is referencing some internal preview that would contain Ruby 3.1. If that is not the case, then excluding the RHEL Ruby 3.1 tests would be the way to go for now.

jackorp avatar Sep 12 '22 15:09 jackorp

Not sure what to do with cccp.yml as it lists centos7.

Remove it. It was only used for CCCP to push Centos images into Centos registries. But we are doing that ourselves now, and ruby 3.1 wont be coming to RHSCL anyway.

I have pushed the devel repo file for RHEL 8 and RHEL 9 as I expect both RHELs to have Ruby 3.1 in some devel repo.

It should be in the RHEL8 devel repo. I do not think we have this option active for RHEL9 though (at least I could not find a reference to it). @phracek can you check? But ruby 3.1 should be in RHEL9 devel repos as well, once they are set up.

[test-all]

pkubatrh avatar Sep 13 '22 06:09 pkubatrh

Looking at some of the RHEL 9 tests, those failed on installing ruby:3.1. Let's exclude that from testing for now.

jackorp avatar Sep 13 '22 07:09 jackorp

[test-all]

pkubatrh avatar Sep 14 '22 08:09 pkubatrh

@jackorp Devel-repo for RHEL9 is added to Testing Farm. Can you please add the .devel-repo-rhel9 file and remove the .exclude-rhel9 file?

phracek avatar Sep 14 '22 13:09 phracek

@phracek done.

jackorp avatar Sep 14 '22 13:09 jackorp

[test-all]

pkubatrh avatar Sep 15 '22 06:09 pkubatrh

RHEL7 - ruby-2.7 and ruby-3.0 is failed on:

[91m[0mLoaded plugins: ovl, product-id, search-disabled-repos, subscription-manager
[91mCould not retrieve mirrorlist https://git.app.eng.bos.redhat.com/git/RH_Software_Collections.git/plain/Containers/osbs-repos-signed-pkgs/pulp_multiarch/x86_64/optional error was
14: curl#60 - "Peer's Certificate issuer is not recognized."
[0m[91m

phracek avatar Sep 15 '22 10:09 phracek

[test-all]

phracek avatar Sep 27 '22 11:09 phracek

[test-all]

zmiklank avatar Sep 27 '22 12:09 zmiklank

@jackorp Can you please rebase common submodule?

phracek avatar Sep 27 '22 12:09 phracek

rebased.

jackorp avatar Sep 27 '22 12:09 jackorp

RHEL7 failures are fixed by #421

phracek avatar Sep 27 '22 13:09 phracek

Tests should be passed for now, excluding CentOS 7 which has an Infra problem.

Fingers-crossed.

[test-all]

phracek avatar Sep 29 '22 08:09 phracek