s2i-nodejs-container icon indicating copy to clipboard operation
s2i-nodejs-container copied to clipboard
verified publisher icon sclorg

Removing langchain.js from testing suite due to yarn is necessary for installation

Open pacostas opened this issue 1 month ago • 6 comments

Removing langchain.js from the testing suite.

This PR removes langchain.js from the testing suite because the yarn binary isn't available on the base images.

Until we further investigate how to properly include and install the yarn binary on the base images to test the langchain.js library, it's better to remove langchain.js. Currently, the failing test is a false alarm indication, as Langchain itself is not failing.

pacostas avatar Nov 17 '25 10:11 pacostas

[test-upstream]

phracek avatar Nov 18 '25 08:11 phracek

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - UpstreamTests - 22-minimalFedora-latestx86_64✅ passed18.11.2025 08:04:295min 39stest pipeline
Fedora - UpstreamTests - 24-minimalFedora-latestx86_64✅ passed18.11.2025 08:04:285min 34stest pipeline
Fedora - UpstreamTests - 20-minimalFedora-latestx86_64✅ passed18.11.2025 08:04:415min 46stest pipeline
CentOS Stream 10 - UpstreamTests - 22-minimalCentOS-Stream-10x86_64✅ passed18.11.2025 08:04:268min 46stest pipeline
CentOS Stream 10 - UpstreamTests - 24-minimalCentOS-Stream-10x86_64✅ passed18.11.2025 08:04:378min 39stest pipeline
RHEL8 - UpstreamTests - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed18.11.2025 08:04:3415min 24stest pipeline
RHEL10 - UpstreamTests - 22-minimalRHEL-10-Nightlyx86_64❌ error18.11.2025 08:04:4317min 20stest pipeline
RHEL9 - UpstreamTests - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 08:04:2718min 41stest pipeline
Fedora - UpstreamTests - 22Fedora-latestx86_64✅ passed18.11.2025 08:04:2621min test pipeline
RHEL9 - UpstreamTests - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 08:04:2820min 20stest pipeline
Fedora - UpstreamTests - 24Fedora-latestx86_64✅ passed18.11.2025 08:04:3221min 6stest pipeline
RHEL10 - UpstreamTests - 24-minimalRHEL-10-Nightlyx86_64❌ error18.11.2025 08:11:0015min 54stest pipeline
CentOS Stream 9 - UpstreamTests - 24CentOS-Stream-9x86_64✅ passed18.11.2025 08:04:2923min 2stest pipeline
CentOS Stream 9 - UpstreamTests - 20CentOS-Stream-9x86_64❌ error18.11.2025 08:04:2823min 53stest pipeline
RHEL8 - UpstreamTests - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed18.11.2025 08:15:0012min 48stest pipeline
CentOS Stream 10 - UpstreamTests - 24CentOS-Stream-10x86_64✅ passed18.11.2025 08:04:2624min 13stest pipeline
CentOS Stream 9 - UpstreamTests - 24-minimalCentOS-Stream-9x86_64✅ passed18.11.2025 08:20:589min 30stest pipeline
CentOS Stream 9 - UpstreamTests - 20-minimalCentOS-Stream-9x86_64✅ passed18.11.2025 08:24:489min 53stest pipeline
RHEL10 - UpstreamTests - 22RHEL-10-Nightlyx86_64❌ error18.11.2025 08:04:2931min 35stest pipeline
RHEL8 - UpstreamTests - 22RHEL-8.10.0-Nightlyx86_64❌ error18.11.2025 08:04:2733min 11stest pipeline
RHEL10 - UpstreamTests - 24RHEL-10-Nightlyx86_64❌ error18.11.2025 08:04:2732min 7stest pipeline
Fedora - UpstreamTests - 20Fedora-latestx86_64❌ error18.11.2025 08:14:4923min 8stest pipeline
RHEL8 - UpstreamTests - 20RHEL-8.10.0-Nightlyx86_64❌ error18.11.2025 08:10:5629min 54stest pipeline
RHEL9 - UpstreamTests - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 08:23:0617min 2stest pipeline
RHEL9 - UpstreamTests - 24RHEL-9.6.0-Nightlyx86_64❌ error18.11.2025 08:04:2636min 40stest pipeline
RHEL9 - UpstreamTests - 20RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 08:04:3836min 22stest pipeline
RHEL9 - UpstreamTests - 22RHEL-9.6.0-Nightlyx86_64❌ error18.11.2025 08:10:4934min 58stest pipeline

github-actions[bot] avatar Nov 18 '25 08:11 github-actions[bot]

Test failed for this reason for Version 20:

 [FAILED] for 'clients' test_client_fastify (00:05:43)
 [FAILED] for 'clients' test_client_pino (00:05:21)

for test_client_fastify:

> [email protected] test
> npm run lint && npm run unit && npm run test:typescript


> [email protected] lint
> npm run lint:eslint


> [email protected] lint:eslint
> eslint


> [email protected] unit
> borp

parsed config: test/**/*.test.js test/**/*.test.mjs
✔ should resolve immediately when reply[kReplyHijacked] is true (1.468486ms)
✖ should reject immediately when reply[kReplyHijacked] is true (0.511853ms)
  TypeError [Error]: t.plan is not a function
      at TestContext.<anonymous> (/opt/app-root/src/test/wrap-thenable.test.js:19:5)
      at Test.runInAsyncScope (node:async_hooks:206:9)
      at Test.run (node:internal/test_runner/test:631:25)
      at Test.processPendingSubtests (node:internal/test_runner/test:374:18)
      at Test.postRun (node:internal/test_runner/test:715:19)
      at Test.run (node:internal/test_runner/test:673:12)
      at async startSubtest (node:internal/test_runner/harness:216:3)

for pino

✔ destination (105.055102ms)
ℹ tests 516
ℹ suites 9
ℹ pass 514
ℹ fail 0
ℹ cancelled 2
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 193520.078485

✖ failing tests:

test at test/multistream.test.js:1:1
✖ /opt/app-root/src/test/multistream.test.js (60003.856481ms)
  'test timed out after 60000ms'

test at test/basic.test.js:1:1
✖ /opt/app-root/src/test/basic.test.js (60007.371521ms)
  'test timed out after 60000ms'
----------------------|---------|----------|---------|---------|------------------------------------
File                  | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                  
----------------------|---------|----------|---------|---------|------------------------------------
All files             |   97.44 |    97.09 |   98.44 |   97.44 |                                    
 src                  |   97.47 |     97.1 |   95.23 |   97.47 |                                    
  browser.js          |   96.23 |    96.93 |   94.59 |   96.23 | 124-125,367-368,375-378,490-500    
  file.js             |     100 |      100 |     100 |     100 |                                    
  pino.js             |     100 |    97.56 |     100 |     100 | 163                                
 src/lib              |   97.42 |    97.08 |     100 |   97.42 |                                    
  caller.js           |   86.66 |    66.66 |     100 |   86.66 | 14-15,23-24                        
  constants.js        |     100 |      100 |     100 |     100 |                                    
  levels.js           |   99.17 |    98.76 |     100 |   99.17 | 225-226                            
  meta.js             |     100 |      100 |     100 |     100 |                                    
  multistream.js      |   99.01 |    98.38 |     100 |   99.01 | 102-103                            
  proto.js            |   99.21 |    97.36 |     100 |   99.21 | 248-249                            
  redaction.js        |     100 |      100 |     100 |     100 |                                    
  symbols.js          |     100 |      100 |     100 |     100 |                                    
  time.js             |     100 |      100 |     100 |     100 |                                    
  tools.js            |   97.16 |    97.43 |     100 |   97.16 | ...122,275,302-303,306-310,343-344 
  transport-stream.js |   66.07 |    81.81 |     100 |   66.07 | 19-26,35-45                        
  transport.js        |    98.2 |       98 |     100 |    98.2 | 47-48,66                           
  worker.js           |   98.45 |     93.1 |     100 |   98.45 | 185-187                            
----------------------|---------|----------|---------|---------|------------------------------------
Test for image 'fedora/nodejs-20:20' FAILED (exit code: 1)
Test for image 'fedora/nodejs-20:20' FAILED (exit code: 1)

phracek avatar Nov 19 '25 09:11 phracek

@pacostas Please address issues in this Pull request as well.

phracek avatar Nov 19 '25 09:11 phracek

@phracek I'm not able to reproduce that locally by using the following commands

cd ./s2i-nodejs-container
make build TARGET=rhel8 VERSIONS=20 BUILD_OPTIONS="-t rhel8_20_builder"
s2i build https://github.com/pinojs/pino.git rhel8_20_builder rhel8_20_pino -e NODE_ENV="development"
docker run -e INIT_WRAPPER=false -e NODE_CMD="npm run test" rhel8_20_pino

Do you know if that is the closest environment that someone can have locally for testing the node modules?

pacostas avatar Nov 19 '25 11:11 pacostas

@phracek This issues are not related to the PR changes. Also fastify and pino do not fail on the nodejs upstream nightly builds. Can you please re-trigger the tests?

pacostas avatar Nov 27 '25 16:11 pacostas