s2i-nodejs-container icon indicating copy to clipboard operation
s2i-nodejs-container copied to clipboard
verified publisher icon sclorg

Fix assemble cache clean order in 16-minimal, 18-minimal

Open SlouchyButton opened this issue 1 year ago • 5 comments

Removal of the cache has to be the last things done in the assemble script. Calling npm after deleting the cache folder will cause npm to recreate it - which will fail during the image test.

Other images apparently have it correctly, for some reason this error is present only in 16-minimal and 18-minimal.

SlouchyButton avatar Oct 18 '24 14:10 SlouchyButton

[test]

SlouchyButton avatar Oct 18 '24 14:10 SlouchyButton

Pull Request validation

Failed

🔴 Failed or pending statuses - Testing Farm - CentOS Stream 10 - 22[error] 🔴 Review - Missing review from a member (2 required)

Success

🟢 Review - Reviewed by undefined

github-actions[bot] avatar Oct 18 '24 14:10 github-actions[bot]

I'm afraid to click approve

afaik two approvals are needed, and it's not yet merging automatically, only sending email that it would.

SlouchyButton avatar Oct 18 '24 14:10 SlouchyButton

@lukaszachy @SlouchyButton Automatic merger is not enabled yet;). Don't worry. See send only mails about PR and what is missing. Syncing upstream -> downstream for RHEL-9.5.0 is also disabled.

phracek avatar Oct 21 '24 07:10 phracek

but is it enought to move cleaning operations before NPM_CACHE

It's hard to test it completely as this issue is present (for some unknown reason) only in the konflux built image, but as far as I tested it, it should resolve the error.

Also, the issue was present only in 16-min and 18-min - this change changes the code to be identical with other version. For some reason, these two containers had the tmp clean and cache clean reversed.

SlouchyButton avatar Oct 21 '24 12:10 SlouchyButton

[test]

phracek avatar Oct 25 '24 09:10 phracek

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - 18-minimalFedora-latestx86_64✅ passed25.10.2024 09:15:2310min 12stest pipeline
Fedora - 18Fedora-latestx86_64✅ passed25.10.2024 09:15:2514min 10stest pipeline
Fedora - 20Fedora-latestx86_64✅ passed25.10.2024 09:17:2715min 26stest pipeline
CentOS Stream 9 - 20CentOS-Stream-9x86_64✅ passed25.10.2024 09:18:3415min 45stest pipeline
RHEL9 - 18-minimalRHEL-9.4.0-Nightlyx86_64✅ passed25.10.2024 09:15:3319min 31stest pipeline
CentOS Stream 10 - 22CentOS-Stream-10x86_64❌ failed04.11.2024 08:47:1110min 48stest pipeline
RHEL9 - 18RHEL-9.4.0-Nightlyx86_64✅ passed25.10.2024 09:15:2721min 3stest pipeline
RHEL8 - 18-minimalRHEL-8.10.0-Nightlyx86_64✅ passed04.11.2024 08:47:1018min 33stest pipeline
RHEL8 - 18RHEL-8.10.0-Nightlyx86_64✅ passed25.10.2024 09:15:2624min 17stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64✅ passed25.10.2024 09:21:4219min 10stest pipeline
RHEL9 - 20RHEL-9.4.0-Nightlyx86_64✅ passed25.10.2024 09:21:0420min 36stest pipeline
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64✅ passed25.10.2024 09:33:128min 26stest pipeline
RHEL8 - 20RHEL-8.10.0-Nightlyx86_64✅ passed25.10.2024 09:15:3627min test pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed25.10.2024 09:23:3720min 12stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed25.10.2024 09:30:4913min 16stest pipeline
Fedora - 22-minimalFedora-latestx86_64✅ passed25.10.2024 09:34:5510min 44stest pipeline
RHEL9 - 22-minimalRHEL-9.4.0-Nightlyx86_64✅ passed25.10.2024 09:35:2417min 30stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed04.11.2024 08:47:1326min 28stest pipeline
RHEL9 - 22RHEL-9.4.0-Nightlyx86_64✅ passed04.11.2024 08:47:1521min 26stest pipeline
RHEL9 - 20-minimalRHEL-9.4.0-Nightlyx86_64✅ passed25.10.2024 09:26:1227min 35stest pipeline

github-actions[bot] avatar Oct 25 '24 09:10 github-actions[bot]