s2i-nodejs-container icon indicating copy to clipboard operation
s2i-nodejs-container copied to clipboard

container_tests: allow sourcing ENV VARS from PR comment

Open zmiklank opened this issue 3 years ago • 3 comments

Tested here: https://github.com/zmiklank/s2i-nodejs-container/pull/1

Also, should this be documented somewhere?

zmiklank avatar Oct 07 '22 08:10 zmiklank

I would prefer to wait till testing CI is not up and running again. For sure.

phracek avatar Oct 11 '22 10:10 phracek

OK. But this change will not appear in this PR's tests results because files of the GitHub Actions are taken from master branch code.

zmiklank avatar Oct 11 '22 10:10 zmiklank

[test]

zmiklank avatar Oct 11 '22 12:10 zmiklank

Is there anything I need to change in this PR in order to merge it? @pkubatrh @phracek

zmiklank avatar Oct 13 '22 06:10 zmiklank

@zmiklank Please rebase it

phracek avatar Oct 19 '22 10:10 phracek

[test-all]

phracek avatar Oct 19 '22 12:10 phracek