postgresql-container icon indicating copy to clipboard operation
postgresql-container copied to clipboard

[DO NOT MERGE] Demonstrate problem in running tests

Open hhorak opened this issue 4 years ago • 1 comments

This PR adds false call in the beginning of tests. Adding such a false call anywhere in the test function should make the tests failed. It is not happening though.

This is caused by the change in running tests, when we wanted to run all tests by default. However, when doing so, set -e setting does not work, because the -e is ignored in all commands under if statement. This is the relevant documentation in the man page bash(1).

If a compound command or shell function executes in a context where -e is being ignored,
none of the commands executed within the compound command or function body will be affected
by the -e setting, even if -e is set and a command returns a failure status.

If a compound command or shell function sets -e while executing in a context where -e is
ignored, that setting will not have any effect until the compound command or the command
containing the function call completes.

hhorak avatar Mar 14 '20 10:03 hhorak

A PR that removes the problematic code in #365.

hhorak avatar Mar 17 '20 14:03 hhorak

We no longer use set -e for getting test results. The testing framework has been partly reworked since 2020. I think this can be closed.

zmiklank avatar Mar 30 '23 13:03 zmiklank

Thanks for taking care, I am closing it

fila43 avatar Mar 30 '23 13:03 fila43