mongodb-container icon indicating copy to clipboard operation
mongodb-container copied to clipboard

Added container-quickstarts as an 'examples' submodule. This contains…

Open jbornemann opened this issue 7 years ago • 16 comments

This contains the updated mongodb statefulset quickstart example from the red hat COP repository. It looks like it might have been copied from there originally.

jbornemann avatar Oct 09 '17 14:10 jbornemann

Can one of the admins verify this patch?

centos-ci avatar Oct 09 '17 14:10 centos-ci

Can one of the admins verify this patch?

centos-ci avatar Oct 09 '17 14:10 centos-ci

Can one of the admins verify this patch?

rhscl-bot avatar Oct 09 '17 14:10 rhscl-bot

This PR looks good to me. Linked container-quickstart contains new information IMPOV.

@jbornemann Is it possible to get commit right into this repository? Also removed README contained some info about scaling replicaset. Mainly about scaling down and absence of removing members from mongodb configuration. So after big scale down replicaset could be unreachable.

omron93 avatar Oct 10 '17 06:10 omron93

Is it possible to get commit right into this repository?

Sorry, not sure what you mean. Do you mean embed the example directly in this repository? Part of the reasoning behind having it be a submodule was to reduce duplication of work. The RH Container COP actively maintains those examples. Let me know if I misunderstand.

Also removed README contained some info about scaling replicaset. Mainly about scaling down and absence of removing members from mongodb configuration. So after big scale down replicaset could be unreachable.

We could certainly add part/all of the document back.

jbornemann avatar Oct 10 '17 13:10 jbornemann

Sorry, not sure what you mean. Do you mean embed the example directly in this repository? Part of the reasoning behind having it be a submodule was to reduce duplication of work. The RH Container COP actively maintains those examples. Let me know if I misunderstand.

I understand. I thought about whats a process of contributing into that repo. And if it would be possible to be added as collaborator to that repo to be able to participate in maintaing of this example...

We could certainly add part/all of the document back.

Thanks.

omron93 avatar Oct 11 '17 06:10 omron93

I understand. I thought about whats a process of contributing into that repo. And if it would be possible to be added as collaborator to that repo to be able to participate in maintaing of this example...

You could ask. I believe Eric Sauer, and Andrew Block are the owners of that repository. You will probably have to create a fork, and submit PRs from your fork.

jbornemann avatar Oct 11 '17 19:10 jbornemann

Thanks @jbornemann, that is very interesting. I'm thinking whether including such a repo as a submodule is the best way here, since the repository includes much more than just mongodb examples. Wouldn't a link from README.md to the remote directory be better? If we want to use the remote templates for testing, we can always download latest template and run it, it doesn't need to be a submodule..

hhorak avatar Oct 16 '17 12:10 hhorak

Sure, that's fine by me. I've updated

jbornemann avatar Oct 16 '17 17:10 jbornemann

Can one of the admins verify this patch?

rhscl-bot avatar Nov 28 '17 15:11 rhscl-bot

Can one of the admins verify this patch?

centos-ci avatar Nov 28 '17 15:11 centos-ci

Can one of the admins verify this patch?

rhscl-bot avatar Feb 17 '18 10:02 rhscl-bot

Can one of the admins verify this patch?

rhscl-bot avatar Feb 11 '19 20:02 rhscl-bot

Can one of the admins verify this patch?

rhscl-bot avatar Mar 09 '19 14:03 rhscl-bot

Can one of the admins verify this patch?

rhscl-bot avatar Jul 19 '19 08:07 rhscl-bot

Can one of the admins verify this patch?

rhscl-automation avatar Sep 03 '20 08:09 rhscl-automation

mongodb container is not maintained any more in this org. closing.

hhorak avatar Apr 10 '24 11:04 hhorak