ngx-mqtt icon indicating copy to clipboard operation
ngx-mqtt copied to clipboard

Encourage the library authors to publish an Ivy distribution

Open cloakedch opened this issue 3 years ago • 3 comments

  • [x] I have searched for similar issues in this repository, but couldn't find one.
  • [x] I have read the README and have a basic understanding how angular works.

I'm submitting a...

  • [ ] Regression (a behavior that used to work and stopped working in a new release)
  • [ ] Bug report  
  • [x] Feature request

Current behavior

As the title suggests, recent angular builds show the following warning when building:

Generating browser application bundles (phase: setup)...Processing legacy "View Engine" libraries:
- ngx-mqtt [es2015/esm2015] (https://github.com/sclausen/ngx-mqtt.git)
Encourage the library authors to publish an Ivy distribution

Expected behavior

Unsure. I guess, ideally, an ivy-compatible build is generated?

Minimal working example of the problem with instructions

n/a

What is the motivation / use case for changing the behavior?

Warning shown by angular build.

Environment


ngx-mqtt version: 9.0.5


- Broker 
Irrelevant

Others:

Angular 13.0.3
npm 8.1.4

cloakedch avatar Nov 22 '21 10:11 cloakedch

I would second this. For some reason the combination Angular 13, Jest and ngx-mqtt breaks our tests. I think it's because this is still a view engine library.

It still works in runtime, so it's some sort of combination of the three. If I run npx ngcc before I run ng test, it does work.

Unexpected value 'MqttModule' imported by the module 'DynamicTestModule'. Please add an @NgModule annotation.

Reproducable example repo: https://github.com/ebosveld/ngx-mqtt-bug-with-angular-13

ebosveld avatar Dec 17 '21 15:12 ebosveld

I would second this. For some reason the combination Angular 13, Jest and ngx-mqtt breaks our tests. I think it's because this is still a view engine library.

It still works in runtime, so it's some sort of combination of the three. If I run npx ngcc before I run ng test, it does work.

Unexpected value 'MqttModule' imported by the module 'DynamicTestModule'. Please add an @NgModule annotation.

Reproducable example repo: https://github.com/ebosveld/ngx-mqtt-bug-with-angular-13

Thats also happening on our side, after updating to Angular 13. @sclausen Do you have any plans on fixing this?

konstantinschuette avatar Apr 26 '22 07:04 konstantinschuette

Unfortunately my current workload enforces me to tighten my priority list and since this is an unpaid side project of mine, I don't think I will have enough spare time for this in the near future. Things might relax a bit, but I wouldn't count on free support for this library soon.

sclausen avatar May 12 '22 19:05 sclausen