akka-kafka icon indicating copy to clipboard operation
akka-kafka copied to clipboard

Can AkkaConsumber inherit from a common base trait?

Open coreyauger opened this issue 8 years ago • 2 comments

I would like to have a common base for akka consumers... to allow for a generic way to process clean-up

ex: private[this] val consumerRegistry = new ConcurrentHashMap[String, AkkaConsumerBase[String, _]] `

def shutdown() = {
    logger.info("Shutting down Event Bus")
    producer.close()
    Await.ready(Future.sequence(consumerRegistry.map(e => e._2.stop())), 5 minute)
  }

Thoughts ?

coreyauger avatar Apr 20 '16 15:04 coreyauger

seems legit, want to do a PR?

sclasen avatar Apr 20 '16 15:04 sclasen

Sounds good :)

coreyauger avatar Apr 20 '16 16:04 coreyauger