scipy icon indicating copy to clipboard operation
scipy copied to clipboard

MAINT: stats.gstd: return result rather than raising

Open mdhaber opened this issue 1 year ago • 2 comments

Reference issue

gh-20285

What does this implement/fix?

gh-20285 noted changes to stats.gstd that would make it more amenable to the addition of array API support. This implements those changes. It also deprecates support for masked arrays, since gstd seems to be unique among stats functions in that it advertises support for masked arrays such that it returns a masked array with no masked elements (many handle them, but other functions return regular arrays).

Additional information

See https://github.com/scipy/scipy/pull/20285#issuecomment-2015706838 for context and additional rationale.

mdhaber avatar May 11 '24 02:05 mdhaber

@mdhaber We've had two approvals on the mailing list and the failures on the CI are unrelated. Would you like to add anything before I give it a final review?

Kai-Striega avatar May 16 '24 02:05 Kai-Striega

Besides the suggestions, nope. Feel free to commit those before merge.

mdhaber avatar May 16 '24 03:05 mdhaber

Looks like CI is happy. I took the liberty of assuming this would make it and adding a release note.

mdhaber avatar May 25 '24 12:05 mdhaber

Merged, thanks for your work @mdhaber!

Kai-Striega avatar May 25 '24 23:05 Kai-Striega