scipy-cookbook icon indicating copy to clipboard operation
scipy-cookbook copied to clipboard

slice in https://github.com/scipy/scipy-cookbook/blob/master/ipython/SignalSmooth.ipynb

Open louking opened this issue 6 years ago • 1 comments

Sorry not sending pull request as I am not sure I am correct. But I tried returning the slice suggested and had different output length. I am not sure of the math and how numpy.convolve works but my correction seems to pull the "middle" slice. E.g,. for window_len = 5 my suggested slice omits first two and last two elements.

NOTE: length(output) != length(input), to correct this: return y[(window_len/2-1):-(window_len/2)] instead of just y.

be

NOTE: length(output) != length(input), to correct this: return y[(window_len/2):-(window_len/2)] instead of just y.

louking avatar Dec 25 '17 11:12 louking

Thanks @louking, that seems to be correct. With the suggestion as given now, y.shape = (101,) while x.shape = (100,).

@WarrenWeckesser agreed that that's the way to change it?

rgommers avatar Dec 26 '17 03:12 rgommers