libsnark
libsnark copied to clipboard

Published 20 hours ago •

Reame
Issues

Clang Support

Open Maroc-OS opened this issue 8 years ago • 7 comments

Why not thinking about adding Clang Support? the code is not clean enough, and have to be standardised, clang does not accept to compile it because of that.

Must of problems are "invalid operands to binary expression" because of mal-placements of templates/functions.

Clang is very powerful in case of code analysis and error reporting, and can help fining more bugs and fixing more problems and even optimizing the code.

Any Chances?

Feb 16 '17 13:02 Maroc-OS

I can fix issues with clang. If done, will that be merged in?

Mar 07 '17 13:03 chfast

@chfast, that would be great! But please do so on top of the cmake branch, which we plan to transition to (#65).

Mar 08 '17 00:03 tromer

The cmake branch sound even better :)

Mar 08 '17 09:03 chfast

i have sent a very small pr about this and i think i have some other patches.

https://github.com/zcash/libsnark/pull/12

Mar 09 '17 23:03 Maroc-OS

Ok, nice. Do you plan to upstream the changes here? How much different is the zcash version?

Mar 10 '17 15:03 chfast

I would love to see this, too

Jan 19 '18 23:01 copumpkin

I have the same issue

Mar 28 '19 18:03 MarkLTZ