scikit-optimize
scikit-optimize copied to clipboard
scikit-optimize
Move CI to GitHub Actions
Fixes https://github.com/scikit-optimize/scikit-optimize/issues/1060 Closes https://github.com/scikit-optimize/scikit-optimize/pull/1072 Closes https://github.com/scikit-optimize/scikit-optimize/issues/1068 Closes https://github.com/scikit-optimize/scikit-optimize/pull/1069 Fixes https://github.com/scikit-optimize/scikit-optimize/issues/1073
This took a while, but it's often better late than never. :sweat_smile:
The PR looks huge, but it's namely about:
- migrating the whole of CI onto GitHub Actions (purging TravisCI and CircleCI machinery so we don't have dead code lying around),
- improving setup.py to aid in releasing (specifying dependencies in one single place, version control by version control etc.),
- cleaning the code to conform to (hereby finally active!) linting,
- some documentation consolidation and improvements (README.rst, CONTRIBUTING.md, ISSUE_TEMPLATE.md ...) to help new users.
I tried my best to simplify, yet continue @holgern's work—what happened, man, have you died?! :D
It's not too pretty, and it's opinionated in some places, but it's what I can offer and am willing to maintain. The commits have been roughly squashed by function. The PR is at this point certainly ready for review. You can see all the checks passing on a PR to my fork, here.
Hello @kernc! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
benchmarks/bench_ml.py:
Line 155:80: E501 line too long (88 > 79 characters) Line 247:80: E501 line too long (85 > 79 characters) Line 249:80: E501 line too long (96 > 79 characters) Line 286:80: E501 line too long (87 > 79 characters) Line 287:80: E501 line too long (86 > 79 characters)
- In the file
examples/interruptible-optimization.py:
Line 52:1: E305 expected 2 blank lines after class or function definition, found 1 Line 52:80: E501 line too long (99 > 79 characters)
- In the file
examples/plots/visualizing-results.py:
Line 113:1: E402 module level import not at top of file
- In the file
examples/sampler/sampling_comparison.py:
- In the file
setup.py:
Line 13:80: E501 line too long (83 > 79 characters)
- In the file
skopt/__init__.py:
Line 40:80: E501 line too long (81 > 79 characters)
Comment last updated at 2021-10-11 20:15:31 UTC
@pep8speaks in https://github.com/OrkoHunter/pep8speaks/issues/95 says it should follow setup.cfg flake8 configuration, but apparently not the case?
I'd kindly motion toggling off the noise in favor of a more simple lint check. :+1:
