scikit-learn icon indicating copy to clipboard operation
scikit-learn copied to clipboard

Quantile transformer sample weight

Open snath-xoc opened this issue 1 month ago • 4 comments

Reference Issues/PRs

Follow up on previously closed PR #31147 and issue #30707

What does this implement/fix? Explain your changes.

Adds sample weights within the QuantileTransformer under preprocessing using the _weighted_percentile function.

snath-xoc avatar Nov 21 '25 14:11 snath-xoc

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: fa29103. Link to the linter CI: here

github-actions[bot] avatar Nov 21 '25 14:11 github-actions[bot]

@ogrisel and @kaekkr

snath-xoc avatar Nov 21 '25 14:11 snath-xoc

Hmmmm I am running with an issue that seems similar to here: https://github.com/actions/runner/issues/449

snath-xoc avatar Nov 22 '25 22:11 snath-xoc

the integration of _weighted_percentile and the updates based on earlier review feedback look like a solid step toward bringing sample-weight support to QuantileTransformer. good to see the switch to the unified _weighted_percentile logic — that aligns with recent changes in utils.stats. as @ogrisel mentioned earlier, using percentile ranks correctly (per feature and per reference value) will be key for correctness.

Mohataseem89 avatar Dec 08 '25 15:12 Mohataseem89