scikit-matter icon indicating copy to clipboard operation
scikit-matter copied to clipboard

Published 20 hours ago • verified publisher icon scikit-learn-contrib

Making the trace component of SparseKernelNormalizer more memory-frie…

Open rosecers opened this issue 2 years ago • 1 comments

…ndly

Using the equality of traces under cyclic products, I've modified the sparse kernel normalizer to be less memory-hungry. Had a few issues using this and having RAM crash

Contributor (creator of PR) checklist

  • [x] Tests updated (for new features and bugfixes)?
  • [x] Documentation updated (for new features)?
  • [x] Issue referenced (for PRs that solve an issue)?

For Reviewer

  • [x] CHANGELOG updated if important change?

:books: Documentation preview :books:: https://scikit-matter--219.org.readthedocs.build/en/219/

rosecers avatar Nov 17 '23 23:11 rosecers

What is the status here?

Seems like we have to fix some assertions in the test_sparse_kernel_centerer.py

PicoCentauri avatar Feb 16 '24 08:02 PicoCentauri